search

wmo-im / GTStoWIS2

Conversion of GTS headers to WIS2 topic
GNU General Public License v3.0
8 stars 6 forks source link

identify authoritative source for CCCC. #4

Open petersilva opened 4 years ago

petersilva commented 4 years ago

It seems there are parallel efforts, and a difficulty in maintaining consistent metadata. WIGOS uses a different, more modern naming scheme, but no known source of mappings between WIGOS and the CCCC codes used on the GTS exists. Without such a mapping, maintainers need to maintain a largerly overlapping list of CCCC codes. It is likely much less work for everyone if a CCCC code were included as a field in the WIGOS data where it is appropriate, and then the CCCC table would be a straight-forward extraction from WIGOS.

antje-s commented 3 years ago

Would be good to add a CCCC field to OSCAR...

petersilva commented 3 years ago

Another question... I found a bunch of missing CCCC''s... I just added them to the main branch for now. You can check them out... commits:

f13de45

0d075e2

788f045

I think the entries are better than being missing... but unsure how to vet additions... at some point we will bless a version, and from that point we will need to be more official about changes ?

petersilva commented 3 years ago

TJDP is somewhere in Puerto-Rico... don't know where... adding.

petersilva commented 3 years ago

and some more in Romania 0d223c888eff64ccf50f61a1841ebb748b4ca599

petersilva commented 3 years ago

When I google "how many airports are there in the world" the answer is 17,678 commercial airports. there is 5954 lines in TableCCCC.json.... Should every airport have a CCCC?

petersilva commented 3 years ago

found this. got an API key:

https://www.icao.int/safety/iStars/HTMLPage/API-Data-Service.html

some more missing ones... RQST as in ...

SMIN90_RQST_190600_de505b4a36d906de5ae98059e445f937.txt

is not in any IATA list either... seems to be over India, but not India... could be some islands in the indian ocean... I do not know what country it is in. leaving it in "unknown"

petersilva commented 3 years ago

We should probably fill in the CC field in TableC1... that will help a lot at least so things show up in the correct country, rather than "unknown". 400759dd8b3169c51a5599c13d9243714aac75d0

antje-s commented 3 years ago

At the moment I am also of the opinion that we should add as many CCCC values as possible...thanks for the API-Data-Service link

petersilva commented 2 years ago

@chenxiaoxia2019 fyi...

chenxiaoxia2019 commented 2 years ago

@petersilva Thanks, Peter. As discussed in the meeting, the starting point of the CCCC table was from WMO website (pdf version), and then how many other lists have you integrated into the current table? I will try to bring this issue to TT-GISC and come up with a more stable working procedure for updating the table CCCC upon requests of other NMHSs.

petersilva commented 2 years ago

@chenxiaoxia2019 have a look here: https://github.com/wmo-im/GTStoWIS2/tree/main/deriving_CCCC

in the comments of the .py files, it describes what was done...

produced an initial CCCC than then went through a lot of hand editing, and incremental improvement from @antje-s and I.

petersilva commented 2 years ago

@chenxiaoxia2019 I think it makes sense to assign this issue to you? You seem to be working on the topic already. hope this is OK with you.

chenxiaoxia2019 commented 2 years ago

@petersilva Yes, I will work on it. @antje-s I checked the current TableCCCC with our recent request from DWD and found that EUMA has already been used for EUMETSAT Metop-SG, so last week we discussed with Simon to assign EUMB for EUMETSAT Athens DB Site. The newly added CCCC is here . Shall I pull request it?

petersilva commented 2 years ago

sure! I think you are saying you are going to do a PR adding a new CCCC to the table? that would be great!