wmo-im / GTStoWIS2

Conversion of GTS headers to WIS2 topic
GNU General Public License v3.0
8 stars 5 forks source link

meaning/specification of id in GEOjson records. #85

Closed petersilva closed 2 years ago

petersilva commented 2 years ago

from #78, ET-AT is asking for replacement of RelPath by id. and a topic.

in v03, id is chosen because it is almost required in geojson... but all existing examples:

So the id can be a uuid or some other randomish generated key with a very wide scope.

In the same message payload, we also need/want to have the topic hierarchy. and logically products in a different topic hierarchy are not the same, so including the topic hierarchy in the id makes for a shorter key.

So then the id will need to contain the topic hierarchy, and some sort of record to identify this product or record within the topic. in my mind this is exactly the function of relPath in v03 format. so it would amount to renaming v03 'relPath' fo v04 'id'

josusky commented 2 years ago

For de-duplication we have the "integrity" field. We could split the "relPath" into the topic/hierarchy part and the instance name/ID part as that is its meaning, as I have mentioned in https://github.com/wmo-im/GTStoWIS2/issues/82#issuecomment-1102405834 but would that really help? On one hand we have been asked not to separate "baseURL" that is difficult to separate (once joined with the "path" element), and on the other hand we would split something that is easy to separate. Confusing.

petersilva commented 2 years ago

based on ET-AT update 2022/05/09 "id" is again a uuid style thing, but data_id is essentially the same as relPath.

josusky commented 2 years ago

As I already stated during our teleconference, I am OK with an "id" field that I do not use, as long as there is a useful one. The "data_id", is a good name for it. I will add it to the new proposal of the schema (issue #90) and we can close this one.

petersilva commented 2 years ago

further discussion here: https://github.com/wmo-im/wis2-notification-message