Closed blchoy closed 2 years ago
@blchoy did you run the 'check_urls.py' against test or prod?
@amilan17 the program was run against prod.
There are a very large number of changes of different forms on this pull request, which makes it very difficult to review carefully
there are no tests running with respect to this pull request
it seems to not include the contents of the 'master' branch, nor be targeting master
i would need to understand the difference between this branch and 'master' before recommending how to proceed. Is this branch derived from 'master'? it does not appear to be able to be merged automatically, according to github checks
indeed the directory structure of this branch is different from 'master'
it appears that the 'check_urls' process in master would not run without minor adaption, due to this updated directory structure
it is hard to gain confidence in differentiating the changes resulting from new entites from the changes due to internal processing, which are not intended to change publihsed entities. i think both of these types of change exist, but i can't tell them apart
@blchoy The ONLY thing that needs to change, right now, is that the TTL folders and files cannot be nested under a TTL directory. This is due to the fact that the upload script expects alignment between the location of the files on the repository and the hierarchy on the codes registry. Therefore, please output the folders under TTL as sisters of the CSV folder instead.
like this:
I think Mark's concerns should be addressed, but they are not critical for the publication of the codes today.
@blchoy Actually, I don't think it's as simple as my proposal just above, but I think I have a way to move forward with publication as is. Will keep you posted.
I'm accepting this PR request as is, because I have enough of what I need to publish the codes, but it doesn't quite do it the right way and it will need more improvement.
These are the manual steps I took to publish to testwmocodes.metarelate.net
I did create the files meeting the requirements in Anna's post, but the check_urls.py script gave even more errors than the previous ones. This is interesting as the only difference between the two sets of TTL files is the top level directory (i.e. /TTL).
Have a discussion with Mark just now and it seems to me that further refinements will have to be made to attain consistencies among the CSV files and the existing tables on the registry, especially the latter tables were created at different times in the past decade.
This PR involves committing TTL generation scripts and the resulting files for IWXXM 2021-2. Highlights of changes include:
The output file of check_urls.py running against prod is in here, and it is in agreement with the changes we have made to the tables.