search

wmo-im / iwxxm

XML schema and Schematron for aviation weather data exchange
https://old.wmo.int/wiswiki/tiki-index.php%3Fpage=TT-AvXML
48 stars 22 forks source link

Update schematron and METAR example for validation #152

Closed mgoberfield closed 5 years ago

mgoberfield commented 5 years ago

Addresses #140 without addition of srsNames

blchoy commented 5 years ago

Thank you. I am trying to list out all geospatial objects in IWXXM in the wiki page (https://github.com/wmo-im/iwxxm/wiki/Geospatial-objects-in-IWXXM) to make sure that we will not miss anything in the implementation. May be we review and merge the PR after the study?

mgoberfield commented 5 years ago

Of course, Choy! You are the benevolent dictator of the repository. You do not have to accept junk.

mark

On Tue, Apr 2, 2019 at 12:20 PM BL Choy notifications@github.com wrote:

Thank you. I am trying to list out all geospatial objects in IWXXM in the wiki page ( https://github.com/wmo-im/iwxxm/wiki/Geospatial-objects-in-IWXXM) to make sure that we will not miss anything in the implementation. May be we review and merge the PR after the study?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wmo-im/iwxxm/pull/152#issuecomment-479076993, or mute the thread https://github.com/notifications/unsubscribe-auth/AHfSTaFCV08iYCBNnU8rS5XoiYwdLZzOks5vc4NQgaJpZM4cX1VT .

blchoy commented 5 years ago

Hi @mgoberfield, I have listed out all geospatial objects in IWXXM in https://github.com/wmo-im/iwxxm/wiki/Geospatial-objects-in-IWXXM. May I ask your kind assistant to take a look? Feel free to edit. Of course, some objects like iwxxm:tropicalCyclonePosition now seems to be necessary to have CRS included and we may need to update the examples accordingly.

mgoberfield commented 5 years ago

Hi Choy (@blchoy ),

I will get out my red pen and 🔍

mgoberfield commented 5 years ago

Initial sweep of the draft done, @blchoy. I added the case as it requires a 3-D CRS since the summit height of the volcano is not represented separately in the feature.

blchoy commented 5 years ago

Initial sweep of the draft done, @blchoy. I added the metce:EruptingVolcano case as it requires a 3-D CRS since the summit height of the volcano is not represented separately in the feature.

Looks like a deficiency to me :( I have already raised an issue (#153) for an urgent fix to this. Let's discuss later today during the TT-AvXML telecon. @marqh please note.

blchoy commented 5 years ago

Thanks @mgoberfield for contributing. I have extended your code on CRS checking in RC3 which will be made available in a separate PR.