search

wmo-im / iwxxm

XML schema and Schematron for aviation weather data exchange
https://old.wmo.int/wiswiki/tiki-index.php%3Fpage=TT-AvXML
48 stars 22 forks source link

Added new rules for Advisories to allow empty TEST messages to validate. #221

Closed mgoberfield closed 3 years ago

mgoberfield commented 4 years ago

Minor changes from 'I' to 'i' elsewhere.

Confirmed changes to schematron still validates documents in examples/ folder.

Respectfully submitted for review.

blchoy commented 3 years ago

Thank you for creating the pull request. I have:

  1. Downloaded the new examples and will be using them in Version 3.1.0 rather than 3.0.1 as these are new introductions which are not too good to be included in a patch
  2. Applied corrections to the typos in iwxxm.sch in Version 3.0.1RC1

With regard to the examples, while the TAC messages has only two lines, they will normally be issued with WMO AHL so there is indeed additional information on issue time and issuing centre. In the current design, IWXXM reports also carries elements for these items so that once the COLLECT envelop has been removed it still carry such information. I would suggest to make these elements mandatory in NON-OPERATIONAL reports even though their TAC counterparts are not to ensure compatibility and usefulness of IWXXM reports when it has no COLLECT envelop.