search

wmo-im / iwxxm

XML schema and Schematron for aviation weather data exchange
https://old.wmo.int/wiswiki/tiki-index.php%3Fpage=TT-AvXML
48 stars 22 forks source link

IWXXM Version 3.0-dev #230

Closed blchoy closed 4 years ago

blchoy commented 4 years ago

This is IWXXM Version 3.0-dev with bug fixes and improvements to the schematron rules in iwxxm.sch, examples and guidance. The schemas, except possibly the version number, are unchanged in this version. Please refer to the release notes for details of the changes.

mgoberfield commented 4 years ago

Please consider removing the following lines from the catalog template file:

<rewriteSystem systemIdStartString="http://www.aixm.aero/schema/5.1.1_profiles/AIXM_WX/5.1.1a" rewritePrefix="${INSTALL_DIR}/externalSchemas/aero/aixm/5.1.1_profiles/AIXM_WX/5.1.1a"/>
<rewriteSystem systemIdStartString="http://www.aixm.aero/schema/5.1.1_profiles/AIXM_WX/5.1.1b" rewritePrefix="${INSTALL_DIR}/externalSchemas/aero/aixm/5.1.1_profiles/AIXM_WX/5.1.1b"/>

As we aren't using the WX profile of AIXM.

To be replaced with

<rewriteSystem systemIdStartString="http://www.aixm.aero/schema" rewritePrefix="${INSTALL_DIR}/externalSchemas/aero/aixm"/>

This will allow CI to run without having to access AIXM web site.

Preliminary testing shows that #226 is fixed. I give 👍 to proceed to post 3.0.1RC1

blchoy commented 4 years ago

You have eagle eyes...

Apart from this, do you think it is good to roll back to the original imports instead of iwxxm.xsd?

mgoberfield commented 4 years ago

Yes.

blchoy commented 4 years ago

Okay. Give me some time I will commit the changes on top of the current PR.

blchoy commented 4 years ago

Oops! You are so fast! I go to grab an ice cream and in no time you have approved the changes. 🥇

Have a nice weekend.

mgoberfield commented 4 years ago

Thanks Choy. You have a nice weekend to relax and catch up on much-needed sleep. Do I perform the squash and merge, or do we wait for @marqh to sign off on it too?

blchoy commented 4 years ago

Yes please. I think Mark H is too busy to follow up.