search

wmo-im / iwxxm

XML schema and Schematron for aviation weather data exchange
https://old.wmo.int/wiswiki/tiki-index.php%3Fpage=TT-AvXML
48 stars 22 forks source link

Issue#239 #240

Closed mgoberfield closed 3 years ago

mgoberfield commented 3 years ago

Making a pull request

In making a pull request, please make sure that both the model under wmo-im/iwxxm-modelling and wmo-im/iwxxm are sychnchronized, and correct version of model's exported XMI file and HTML documentation are in wmo-im/iwxxm.

mgoberfield commented 3 years ago

@blchoy - This is the GitHub Action candidate replacement for CI. The initial push to my fork failed to run the script due to a <tab> character in the new YAML file. Subsequent pushes failed to rerun the script. I will continue to see if I can get it to rerun via API. If this YAML file is accepted, it will run whenever there is a PR or push. I've also updated the validation scripts to run with python 3.8 as well as 2.7.

mgoberfield commented 3 years ago

@blchoy Please see this link on results of the new YAML file.

blchoy commented 3 years ago

Thank you. The patches have been included in commit [c3b2885](https://github.com/wmo-im/iwxxm/commit/c3b2885ada6f9a67ca66f94ef52d92459ac47f920 to branch 2021-2RC1 and the PR is no longer required.

mgoberfield commented 3 years ago

I assure you that my changes in this pull request did work. Do you want me to investigate the validation errors?

blchoy commented 3 years ago

It is because of the missing code lists on the online registry. I need to patch the code to accept local RDF files.