search

wmo-im / iwxxm

XML schema and Schematron for aviation weather data exchange
https://old.wmo.int/wiswiki/tiki-index.php%3Fpage=TT-AvXML
48 stars 22 forks source link

Non-existent NIL reason in guidance #270

Closed mgoberfield closed 3 years ago

mgoberfield commented 3 years ago

It was really an inappropriate selection for a nil reason, @blchoy!

https://github.com/wmo-im/iwxxm/blob/8383493c84c63fad342b0f3fbc24070cf7394160/IWXXM/examples/TAC-to-XML-Guidance.txt#L206

Of the fixes I could think of, all of them were inapplicable for this situation.😄

blchoy commented 3 years ago

Haha, the only thing inappropriate is the nilReason itself! Will fix.

A second thought: It would be nice if our CI script can also check the nilReason URIs if present. Something for consideration in the future.

blchoy commented 3 years ago

I think we have finished this one and is therefore closed.

mgoberfield commented 3 years ago

The invalid value for nilReason is still there in RC2

https://github.com/wmo-im/iwxxm/blob/6136d033723b85cb193a2adbddbd040ee5c8dd8f/IWXXM/examples/TAC-to-XML-Guidance.txt#L206

Thus, I do not think it's closed yet. In the case of CB location set to NIL, this information is conveyed in XML with nilReason set to inapplicable

blchoy commented 3 years ago

Thus, I do not think it's closed yet. In the case of CB location set to NIL, this information is conveyed in XML with nilReason set to inapplicable

My apologies for overlooking this one. This is now fixed with commit https://github.com/wmo-im/iwxxm/commit/3bff2a4b1e1ec7721ea083e6ecfc14a382fd0809