search

wmo-im / iwxxm

XML schema and Schematron for aviation weather data exchange
https://old.wmo.int/wiswiki/tiki-index.php%3Fpage=TT-AvXML
48 stars 22 forks source link

FT2021_2RC2 #272

Closed blchoy closed 3 years ago

blchoy commented 3 years ago

First commit of IWXXM 2021-2RC2. Significant changes include:

  1. Implement changes to SIGMET in Amendment 79 Discussion 267, including the schema/schematron rules and examples.
  2. Update examples of SIGMET, VAA and SWA to correct the orientation (counter-clockwise) of the points in a polygon enclosing a phenomenon
  3. Change the version of all schemas and examples from RC1 to RC2.

Do not squash and merge this PR. Only check and approve the changes and leave this branch untouched.

blchoy commented 3 years ago

@amilan17 I think we can pack up and upload to schemas.wmo.int right now.

mgoberfield commented 3 years ago

HOLD!

Please fix https://github.com/wmo-im/iwxxm/blob/3b7d03ba782a0afef89060b58623836040002f73/IWXXM/tropicalCycloneAdvisory.xsd#L103

That element needs to be made nillable @blchoy. Very sorry that I did not catch this or thought of this yesterday. I realized this omission when I woke up this morning!

blchoy commented 3 years ago

Please fix

https://github.com/wmo-im/iwxxm/blob/3b7d03ba782a0afef89060b58623836040002f73/IWXXM/tropicalCycloneAdvisory.xsd#L103

That element needs to be made nillable @blchoy. Very sorry that I did not catch this or thought of this yesterday. I realized this omission when I woke up this morning!

Done with commit https://github.com/wmo-im/iwxxm/commit/6136d033723b85cb193a2adbddbd040ee5c8dd8f

Some people say their minds keep figuring out solutions when they are sleeping and will most likely get one when they wake up. Now I know this is true. ;)

blchoy commented 3 years ago

A new commit https://github.com/wmo-im/iwxxm/pull/272/commits/3bff2a4b1e1ec7721ea083e6ecfc14a382fd0809 was made to handle the remaining documentation issues in #250 and #270.

blchoy commented 3 years ago

Another commit https://github.com/wmo-im/iwxxm/pull/272/commits/d06fa3f815e71ae619bf6f07d5acaa91a8224527 was made for removing the schematron rule mentioned in #250.

blchoy commented 3 years ago

Seems to me that most issues relevant to IWXXM 2021-2RC2 have been fixed. The last one could be #271, and it will be done with a new branch FT2021-RC2-refactor. This PR is therefore closed.