search

wmo-im / iwxxm

XML schema and Schematron for aviation weather data exchange
https://old.wmo.int/wiswiki/tiki-index.php%3Fpage=TT-AvXML
48 stars 22 forks source link

First commitment of IWXXM 2023-1RC1 #312

Closed blchoy closed 1 year ago

blchoy commented 1 year ago

This pull request incorporates changes to IWXXM 2021-2 with regard to:

  1. iwxxm.sch bugs involving SIGMET (#293), and
  2. The missing representation for airframe icing phenomenon in the WAFS SIGWX F/C package (#294)
jkorosi commented 1 year ago

I have an additional question: Should the maximum of supplementaryAnalysisCollection be limited to 1? I did not find any rule which says that only one 1 CB is allowed. <element name="supplementaryAnalysisCollection" minOccurs="0" maxOccurs="1">

blchoy commented 1 year ago

I have an additional question: Should the maximum of supplementaryAnalysisCollection be limited to 1? I did not find any rule which says that only one 1 CB is allowed. <element name="supplementaryAnalysisCollection" minOccurs="0" maxOccurs="1">

Strictly speaking your suspicion is valid, there is no such constraint documented. I will make an update to it today.

blchoy commented 1 year ago

@jkorosi could you take a look at commit 65104a0 to double confirm your suggestions (viz your comment and PR) have been properly implemented?

jkorosi commented 1 year ago

It seems OK.