wmo-im / iwxxm

XML schema and Schematron for aviation weather data exchange
https://old.wmo.int/wiswiki/tiki-index.php%3Fpage=TT-AvXML
48 stars 22 forks source link

Missing <quantity> tag defining quantity-kind (e.g. heightAtTopOfCloud) in the schemas #34

Closed marqh closed 6 years ago

marqh commented 6 years ago

related to #20

is http://codes.wmo.int/common/c-15/me/heightOfTopOfCloud

explicitly part of IWXXM 2.1?

Is this:

is there a bug in the export

blchoy commented 6 years ago

There is indeed a sequence "0 20 014" describing "Height of top of cloud" in BUFR Table B/20:

image

This is being referenced in iwxxm:AIRMETEvolvingCondition/@cloudTop which is analogous to that referenced in iwxxm:AIRMETEvolvingCondition/@cloudBase.

braeckel commented 6 years ago

The question would be why it is present in UML but not in the resulting XML schema. Overall @marqh this appears to be a code entry that should be retained, and we should track down the UML -> XML schema translation issue.

After digging in further it appears that the only XSD reference to cloud types in http://codes.wmo.int/common/quantity-kind/ is coming from common.xsd on CloudLayerType/base. Neither AIRMET nor SIGMETEvovingCondition (both of which have cloudBase and cloudTop) are carrying the quantity metadata properly out to XSD. One difference may be that CloudLayerType/base references the DistanceWithNilReason whereas *EvolvingCondition/cloudTop and cloudBase references a Distance. All three UML references have a "quantity" tagged value set.

blchoy commented 6 years ago

Oh I see. You are not only referring to the missing item in the code registry (#20) but the missing "quantity" tag in the schema. The latter is related to the fact that the EA serialization adaptation in accordance to our request some years ago did not cover the case where the tagged value is associated with an UML class attribute. This is, however, not too difficult to handle in our post-processing XSLT and I will see if I can fix this over the weekend.

blchoy commented 6 years ago

I have completed updating the style sheets used to generate the schemas and AIRMET.xsd should now have the necessary quantity tags and information. AIRMET.xsd and Release Notes have been updated accordingly.

marqh commented 6 years ago

http://codes.wmo.int/common/quantity-kind/heightAtTopOfCloud is required

blchoy commented 6 years ago

As the item in the code registry will be followed in #20, I am closing this ticket to simplify tracking.