search

wmo-im / iwxxm

XML schema and Schematron for aviation weather data exchange
https://old.wmo.int/wiswiki/tiki-index.php%3Fpage=TT-AvXML
49 stars 22 forks source link

Schematron rules merged into iwxxm.sch #87

Closed braeckel closed 6 years ago

braeckel commented 6 years ago

Closes #60, Closes #32. Removed iwxxm-collect.sch and iwxxm-collect-codelists.sch. Updated iwxxm.sch contents to include both Collect and Codelist-related rules, this single SCH file now includes the exact contents that used to be in iwxxm-collect-codelists.sch. iwxxm-collect.sch only included a single additional rule which was only triggered against Collect messages (was safe to merge), and iwxxm-collect-codelists.sch had additional namespaces and CodeList rules that are now part of the IWXXM standard Schematron checks.

@blchoy Further changes to the CodeLists-related rules are probably necessary (for example, id names might be improved) but this can follow this PR and will be independent of the issues being addressed here. The Schematron file more generally will also likely need to be regenerated/updated based upon recent changes such as #50 and #27, and the Schematron-generation process changes to generate only a single SCH file (instead of three) will need to be changed. It is your call as to whether you would like to check in these changes as part of this PR or as a separate set of changes after this PR.

braeckel commented 6 years ago

The build failures will be resolved when this PR is merged, this was caused by Crux limitations that are resolved with Crux 1.3 (now the version on master)

blchoy commented 6 years ago

Would like to update the schematron generating XSLT before merging the PR. I have made a suggestion in #60 with regard to the ids of the rules involving codelists.

braeckel commented 6 years ago

My apologies, I just caught up to your last comment on this issue and I should not have merged this PR. I'm not sure it is possible to reverse the merge, are you comfortable addressing this as part of the broader Schematron changes discussed here and elsewhere?

blchoy commented 6 years ago

No problem for the merge. In fact we need to create another PR once we finished updating the schematrons rules.