search

wmo-im / pywcmp

pywcmp provides validation and quality assessment capabilities for the WMO WIS Core Metadata Profile (WCMP)
https://community.wmo.int/activity-areas/wis
Other
9 stars 8 forks source link

KPI_002, non-printable characters in title incorrectly identified. #62

Closed david-i-berry closed 2 years ago

david-i-berry commented 2 years ago

https://github.com/wmo-im/pywcmp/blob/30259599a44ab1839d36248b89f9d4afc0207d11/pywcmp/kpi.py#L227

Test fails when title contains punctuation or spaces, e.g.

title = "My Great Dataset Title"
title.isalnum()

returns False

Suggest using isascii().

tomkralidis commented 2 years ago

cc @josusky

PR in #63. I've also dropped CI testing for Python 3.6 (it's time, and isascii was introduced in 3.7).