Add validation of KPI 13

wmo-im / pywcmp

pywcmp provides validation and quality assessment capabilities for the WMO WIS Core Metadata Profile (WCMP)

https://community.wmo.int/activity-areas/wis

Other

9 stars 8 forks source link

Closed josusky closed 2 years ago

josusky commented 2 years ago

That was the last KPI that we described (in July 2021) and somehow we forgot to implement it in the pywcmp tool. (see https://github.com/wmo-im/wcmp/issues/120)

amilan17 commented 2 years ago

Is it possible to test for the current rules stated in KPI 13? I think we can only test for the presence of the element and "::" ...

The WMO Core Metadata Profile recommends the use of a URI for `gmd:fileIdentifier` attributes. The URI should be structured as follows:

[ ] Fixed string `urn:x-wmo:md:`
[ ] Citation authority based on the Internet domain name of the data-provider organization, e.g. “int.wmo.wis”, “gov.noaa”, “edu.ucar.ncar”, “cn.gov.cma” or “uk.gov.metoffice”
[x] Double separator colons: `::`
[ ] Unique identifier (in scope of the citation authority)

josusky commented 2 years ago

I am sure we can test the first (fixed) part "urn:x-wmo:md:", that is easy :-)
The second part is more tricky but something can be done: we can test the structure of the identifier and the first level (e.g. "edu", "cn") off-line if we want (and have enough time) we can resolve the whole thing to see if it is a valid domain name, for example, "ncar.ucar.edu" resolves to "23.185.0.1", in other words, it is a valid DNS entry. When it concerns the uniqueness of the identifier, there I suggest not to even try. After all, the KPI talks about structure, that is syntax not so much about the semantics.

amilan17 commented 2 years ago

Don't add for 1.3 KPIs