search

wmo-im / pywcmp

pywcmp provides validation and quality assessment capabilities for the WMO WIS Core Metadata Profile (WCMP)
https://community.wmo.int/activity-areas/wis
Other
9 stars 8 forks source link

Update KPI-7 #84

Closed amilan17 closed 1 year ago

amilan17 commented 2 years ago

Testing for gmx:Anchor is too restrictive and during the last cycle of KPI testing all records received a 0 on KPI-7.  

I think we should simplify the XPath for tests 7.1 and 7.2, but then add a 3rd test for gmx:Anchor and change the total score to 3. This is consistent with other KPIs like keywords and data policy. @tomkralidis --OK? 

Change  //gmd:identificationInfo/gmd:MD_DataIdentification/gmd:graphicOverview/gmd:MD_BrowseGraphic/gmd:fileName/gmx:Anchor

//gmd:identificationInfo/gmd:MD_DataIdentification/gmd:graphicOverview/gmd:MD_BrowseGraphic/gmd:fileName

See previous discussions in issue wmo-im/wcmp#124.

josusky commented 2 years ago

The total score was 3 * N, where "N" was number of "graphicOverview" elements. I will fix URL retrieval (to allow use of "gco:CharacterString") and fix the evaluation to take just the first "graphicOverview" into account to ensure that the total score is not more than 3 - that is consistent with the changes related to the title element. BTW, the KPI 7 in pywcmp always had three test (as described in https://github.com/wmo-im/wcmp/blob/1.3/kpi/007-graphic-overview-for-non-bulletins-metadata-records.adoc). Current version of the KPI 7 contains only two tests: https://github.com/wmo-im/wcmp/blob/master/kpi/007-graphic-overview.adoc Hm ...

amilan17 commented 1 year ago

deleted.

amilan17 commented 1 year ago

sorry, rescinding last comment. wrong KPI.

amilan17 commented 1 year ago

it's fixed.