search

wmo-im / pywcmp

pywcmp provides validation and quality assessment capabilities for the WMO WIS Core Metadata Profile (WCMP)
https://community.wmo.int/activity-areas/wis
Other
9 stars 8 forks source link

KPI-5 returns score 0 for everything #86

Closed amilan17 closed 11 months ago

amilan17 commented 1 year ago

I recommend that we change the pywcmp for KPI-5 to only test when DOI's exist. This will be consistent with the approach we are taking with KPI-7 (graphic overview). Given that this is a relatively recent practice in metadata management, giving a score of 0 is quite harsh. What do you think?

image

josusky commented 1 year ago

Hm, you mean to set the "total" for the KPI-5 to "0" if there is no '//gmd:identificationInfo//gmd:citation//gmd:identifier//gmd:code/gmx:Anchor' element? BTW, this KPI (it was initially KPI-12) may yield a total score that is a multiple of 3 (i.e. it evaluates all elements that match the aforementioned XPath). Eeek, it sets the total score to 6 if it finds one matching element so the best you can get is 3 of 6. That is really harsh ;-) I will fix that one, but I am not sure about the rest.

josusky commented 1 year ago

OK, I have changed the KPI-5 check in the pywcmp to check only the first matching element and to set the total score to 0 if there is none.

amilan17 commented 1 year ago

thanks.