search

wmo-im / pywmdr

MIT License
0 stars 2 forks source link

Implement KPI 3-3: Data generation #13

Open jbianchi81 opened 2 years ago

jbianchi81 commented 2 years ago

Implement KPI 3-3 according to https://github.com/wmo-im/wmdr/blob/issue42/kpi/3-3.adoc

jbianchi81 commented 2 years ago

@ferrighi -- We may split these up. I'm starting with 1 to 14

ferrighi commented 2 years ago

Yes, I'll do the other half.

jbianchi81 commented 2 years ago

kpis 23, 24 and 25 are missing

jbianchi81 commented 2 years ago

Apparently codelist for samplingProcedure is missing. I found this closed issue: https://github.com/wmo-im/wmds/issues/111 where it was marked as "no longer relevant". Discussion moved to 6-02 sampling Treatment which was included in FT-2021-2

jbianchi81 commented 2 years ago

I created placeholders for 3-3-* and implemented up to 3-3-06: https://github.com/wmo-im/pywmdr/commit/96f0975efae8a6212365d8cb99d7931ed93888d2

Codelist SamplingTreatment (6-02) is not yet published at codes.wmo.int (was part of FT-2021-2). Temporarily, I copied the list from the issue.

ferrighi commented 2 years ago

I have finished the rest, they are part of the PR #14

jbianchi81 commented 2 years ago

3-3-11: diurnalBaseTime is not a property of ReportingType (wmdr1.0)

jbianchi81 commented 2 years ago

implemented 3-3-06 to 3-3-14 https://github.com/wmo-im/pywmdr/commit/0d1084239bffbf18f559e042c37a1e2c1532cea9