search

wmo-im / pywmdr

MIT License
0 stars 2 forks source link

Implement KPI-2-0 #5

Closed jbianchi81 closed 1 year ago

jbianchi81 commented 3 years ago

Implement KPI-2-0: Station characteristics as described in https://github.com/wmo-im/wmdr/blob/issue42/kpi/2-0.adoc

jbianchi81 commented 3 years ago

On 2-0-02 a reference to a code list of time zones is required, which is missing. Also, a static map or web API to get the timezone of a geographic point is required. This issue is addressed here. Temporarily, this is being used.

jbianchi81 commented 3 years ago

On 2-0-10-b "relative elevation" there is no mention of the corresponding code list (http://codes.wmo.int/wmdr/_RelativeElevation. Anyway, comparison to the code list may be implemented if there are no reasons against it.

jbianchi81 commented 3 years ago

Same issue with 2-0-12-b, but on the schema a "EventType" code list is referred while in codes.wmo.int there isn't a list with that name but there is a "EventAtFacility" (http://codes.wmo.int/wmdr/_EventAtFacility). Using that one.

jbianchi81 commented 3 years ago

On 20-0-12-c logEntry/EventReport/description maybe we should set a minimum length for the string. Temporarily set at 100 characters

jbianchi81 commented 2 years ago

Timezones codelist check implemented (https://github.com/wmo-im/pywmdr/commit/7da610a9e516f703c2ede843a1a1943b927e78f2) based on the WMDR proposal: https://github.com/wmo-im/wmds/blob/issue339/tables_en/4-08.csv discussion here: https://github.com/wmo-im/wmds/issues/339

ferrighi commented 2 years ago

I'm getting No module named 'pywmdr.timezone_codelist'. Could it be you have forgotten to push the file timezone_codelist.py?

jbianchi81 commented 2 years ago

Indeed! Now it's here: https://github.com/wmo-im/pywmdr/blob/first-draft/pywmdr/timezone_codelist.py .