wmo-im / wis2-notification-message

WIS 2.0 MQP message to notify users of availability of new data
https://wmo-im.github.io/wis2-notification-message
2 stars 2 forks source link

YAML schema def and security object in repository and pages is different from that published on schemas.wmo.int #135

Closed david-i-berry closed 3 months ago

david-i-berry commented 3 months ago

As per title, the definition of the security object from the links is not consistent between the yaml and JSON versions.

https://github.com/wmo-im/wis2-notification-message/blob/822e61934f409dda6269eea8c150fdf4b87d947a/schemas/notificationMessageGeoJSON.yaml#L149-L151

is not consistent with:

"properties": {
                            "security": {
                                "type": "object",
                                "patternProperties": {
                                    "^[a-zA-Z0-9\\.\\-_]+$": {
                                        "oneOf": [
                                            {
                                                "$ref": "#/definitions/Schema_Reference"
                                            },
                                            {
                                                "$ref": "#/definitions/Schema_SecurityScheme"
                                            }
                                        ]
                                    }
                                }
                            }
                        }

from: https://[schemas.wmo.int/wnm/1.0.0/schemas/wis2-notification-message-bundled.json](https://schemas.wmo.int/wnm/1.0.0/schemas/wis2-notification-message-bundled.json)

tomkralidis commented 3 months ago

@david-i-berry:

david-i-berry commented 3 months ago

OK, I see my error - I was jumping to the wrong definition when I was checking, checking against securityScheme vs Components.properties.securitySchemes