search

wmo-im / wis2-subscription-manager

An Electron application for browsing a WIS2 Global Discovery Catalogue, configuring WIS2 subscriptions, and viewing download metrics.
Apache License 2.0
2 stars 1 forks source link

No option "add topic" for dataset that contain actionable link to mqtt-topic #56

Open maaikelimper opened 4 months ago

maaikelimper commented 4 months ago

For example: image

Show JSON shows there is a channel to subscribe to:

image

(even though the channel does look wrong ?)

RoryPTB commented 4 months ago

The new, more generalised approach to obtaining the topics has been to search for the first string that begins with 'origin/' or 'cache/' in the same link section that contains a MQTT href. This is because some records used a key other than 'channel' to describe the topic hierarchy. Due to this new method, this particular topic isn't being extracted.

So, do we: 1) Also extract this topic, knowing it's invalid. 2) Keep the implementation as-is and change 'No Topic' to 'No Valid Topic'.

maaikelimper commented 4 months ago

I recommend we discuss this issue with @tomkralidis when he is back from holidays