wmo-im / wis2box

WIS2 in a box is a reference implementation of a WMO WIS2 Node
https://docs.wis2box.wis.wmo.int
Apache License 2.0
40 stars 16 forks source link

add optional FTP setup #297

Closed tomkralidis closed 1 year ago

tomkralidis commented 1 year ago

User story

As a wis2box user, I want wis2box to be able to accept data upload via FTP, so that I can upload my data in a lower barrier fashion.

Acceptance criteria

Definition of done

maaikelimper commented 1 year ago

I've added a separate repository for this feature here: https://github.com/wmo-im/minio-ftp-forwarder

I've tested this on the physical wis2box WMO has started to prepare for Zimbabwe

maaikelimper commented 1 year ago

add the option of using 'minio-ftp-forwarder' to our documentation describing data ingestion options

tomkralidis commented 1 year ago

@maaikelimper to add optional docker compose setup in docker/

maaikelimper commented 1 year ago

I need to do some more work to test and prepare standalone images and a docker-compose that reference environment variables from wis2box, to be bumped to sprint-009

maaikelimper commented 1 year ago

I've prepared the image for wis2box-ftp which is now available as ghcr.io/wmo-im/wis2box-ftp published through GHA from https://github.com/wmo-im/wis2box-ftp

I'm wondering how to add this as an option to wis2box, I could introduce another flag '--ftp' so a user could start wis2box with: python3 wis2box-ctl.py --ftp start similar to the '--ssl' option I introduced in 'SSL everywhere'.

@tomkralidis , I'm not sure you agree with this way of adding services to the wis2box-docker-compose-stack. Do you have other ideas how you would like to organize this?

tomkralidis commented 1 year ago

As an extra, I think we should document this in wis2box for optional FTP forwarding workflows, with steps on how to run wis2box-ftp. I don't think this needs to be supported by wis2box-ctl.py proper.

tomkralidis commented 1 year ago

Implemented in #409

tomkralidis commented 1 year ago

To test in a future iteration.