search

wmo-im / wis2downloader

The backend Python package for downloading real-time data from the WIS2 network.
Apache License 2.0
1 stars 1 forks source link

Refactor - non dev mode, disk space limits and file naming #18

Closed david-i-berry closed 5 months ago

david-i-berry commented 5 months ago

Changes to address

Other changes

maaikelimper commented 5 months ago

Please add a ERROR when WIS2DOWNLOADER_CONFIG is not set or the app crashes here:

https://github.com/wmo-im/wis2downloader/blob/minor-fixes/wis2downloader/utils/config.py#L9-L10

maaikelimper commented 5 months ago

Please document the unit for max_disk_usage and which disk it relates to

maaikelimper commented 5 months ago

I added one commit to allow testing with a non SSL secured client

david-i-berry commented 5 months ago

Please document the unit for max_disk_usage and which disk it relates to

Done, see also #16.

maaikelimper commented 5 months ago

Please add an option to disable pywis_topics-validation, I am unsure if this package is ready to be used for topic-validation at this stage.

Please ensure the text on the error-message indicates what causes the topic-validation to fail

python wis2box-ctl.py execute wis2box downloader add-subscription -t bla                                  
Subscription not added
Error: 400
<!doctype html>
<html lang=en>
<title>400 Bad Request</title>
<h1>Bad Request</h1>
<p>Invalid input (Invalid topic=bla It should not contain special characters, backslashes, or escape codes)</p>