wmo-im / wis2downloader

The backend Python package for downloading real-time data from the WIS2 network.
Apache License 2.0
1 stars 1 forks source link

Feature: Add GitHub Actions Workflows #24

Closed RoryPTB closed 3 months ago

RoryPTB commented 3 months ago

Major Changes

Minor Changes

To Note

Future Plans

maaikelimper commented 3 months ago

I have the following comments:

david-i-berry commented 3 months ago

I agree with @maaikelimper, we either add a Dockerfile and use this to build the image or don't build an image. Given that it is pip installable and only based on python I think any dockerisation should be external.

RoryPTB commented 3 months ago

Okay, that makes sense to me. I agree that being pip-installable, providing a Dockerfile on top is unnecessary. I intended for the PR to be pretty modular anyway, so I'll remove the GHCR action.