Closed RoryPTB closed 3 months ago
I have the following comments:
I agree with @maaikelimper, we either add a Dockerfile and use this to build the image or don't build an image. Given that it is pip installable and only based on python I think any dockerisation should be external.
Okay, that makes sense to me. I agree that being pip-installable, providing a Dockerfile on top is unnecessary. I intended for the PR to be pretty modular anyway, so I'll remove the GHCR action.
Major Changes
Minor Changes
To Note
test-code-quality.yml
file. I've left them enabled for now, since they concern the security of the API and also address thepatternProperties
attribute which is apparently unsupported according to OpenAPI 3.0. I'll let Dave look more into this.Future Plans