search

wmo-im / wmds

WIGOS Metadata Standard: Semantic standard and code tables
16 stars 22 forks source link

2-02 Programs/networks: INDAAF instead of IDAF #188

Closed joergklausen closed 3 years ago

joergklausen commented 4 years ago

Proposal
Deprecate entry http://codes.wmo.int/wmdr/ProgramAffiliation/IDAF.
Add new entry:
notation, name, description
INDAAF, INDAAF, International Network to study Deposition and Atmospheric composition in Africa (https://indaaf.obs-mip.fr/)

Reason
This is a correction of a typo / change of name at the source that we need to follow.

Branch
https://github.com/wmo-im/wmds/tree/Issue%23188

Decision IDAF is superseded by INDAAF

joergklausen commented 3 years ago

Branch created at https://github.com/wmo-im/wmds/commit/98fce435742947bb40eb34b17a7fbb7bddd82a5f#diff-a066c50c20373fc15bcd759e58529c31867ae12caecaa7d36ad7627f5e689622. @Netcheva, @tomkralidis Please review and confirm or comment.

tomkralidis commented 3 years ago

+1 pending deprecation strategy.

Netcheva commented 3 years ago

INDAAF (International Network to study Deposition and Atmospheric composition in Africa) has been formed in result of the union of the previously labeled IDAF network (GAW Contributing Network under Agreement Ref. 15744-2015 RES/ARE ) and the “Sahelian Dust Transect” network. An amendment to the old Agreement had been circulated for approval and signatures for the depreciation of IDAF.

fstuerzl commented 3 years ago

According to the deprecation strategy established by @amilan17 in #199 this is an example for the use case "Code needs updates and the concept remains the same, but edits will change the 'notation' that becomes part of the URL ==> supersede with new code".

@tomkralidis, @Netcheva, please review the updated branch: https://github.com/wmo-im/wmds/blob/Issue%23188/tables_en/2-02.csv

joergklausen commented 3 years ago

Both reviewers agree, branch is valid. @amilan17 To be clear, the entry IDAF should disappear and be included in your list of superseded elements. Do we need separate tables here on github to facilitate this workflow? In principle, the current branch should really just replace the existing entry IDAF with INDAAF ...

amilan17 commented 3 years ago

The branch is not ready yet. 

@fstuerzl  -- Can you update this branch so that the superseded term is removed and only referred to in the superseded.txt file? Thanks!

fstuerzl commented 3 years ago

@amilan17 done!

joergklausen commented 3 years ago

Branch validated