search

wmonk / create-react-app-typescript

DEPRECATED: Create React apps using typescript with no build configuration.
3.7k stars 492 forks source link

bump jest version #255

Open rolandjitsu opened 6 years ago

rolandjitsu commented 6 years ago

Would it be possible to bump the version of jest from 20.0.4 to 22.2.x? I'm having some trouble with a monorepo and yarn workspaces currently (due to hoisting of packages).

~And it doesn't look like jest has any breaking changes according to their changelog~ My bad, there are actually lots of changes, but mostly new features.

See https://github.com/facebook/create-react-app/issues/4021.

rolandjitsu commented 6 years ago

I could make a PR. But I'm not sure about the implications of this upgrade.

tehwalris commented 6 years ago

The version was bumped to 22 in this commit. I don't think the change is released yet.

rolandjitsu commented 6 years ago

@tehwalris nope, npm is still at 2.13.0.

tehwalris commented 6 years ago

I've worked around the issue using nohoist in yarn nightly (PR, guide). Specifically, this is my workspace-level package.json:

{
  "private": true,
  "workspaces": {
    "packages": ["my-package", "another"],
    "nohoist": ["**/jest-runner", "**/jest-runner/**"]
  }
}

Hope that helps.

rolandjitsu commented 6 years ago

@tehwalris I will need to wait with that one until there is a stable release (1.4.2 as they plan), but thanks for sharing the guide.

danielkcz commented 6 years ago

Any plans on releasing a new version with this? Either way, I made my own fork with Jest updated. It also includes small addition of loading *.gql files with graphql-tag, but obviously, you don't need to use that :)

@fredyc/react-scripts-ts