search

wmonk / create-react-app-typescript

DEPRECATED: Create React apps using typescript with no build configuration.
3.7k stars 492 forks source link

Husky hooks not working #436

Open romucci opened 5 years ago

romucci commented 5 years ago

Whenever I use this way of creating the react app, and then install husky, the hooks don't seem to work!

Is there something I am doing wrong? :D!

{
  "name": "learning-typescript",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "react": "^16.6.0",
    "react-dom": "^16.6.0",
    "react-scripts-ts": "3.1.0"
  },
  "scripts": {
    "start": "react-scripts-ts start",
    "build": "react-scripts-ts build",
    "test": "react-scripts-ts test --env=jsdom",
    "eject": "react-scripts-ts eject"
  },
  "devDependencies": {
    "@types/jest": "^23.3.7",
    "@types/node": "^10.12.0",
    "@types/react": "^16.4.18",
    "@types/react-dom": "^16.0.9",
    "husky": "^1.1.2",
    "typescript": "^3.1.3"
  },
  "husky": {
    "hooks": {
      "pre-commit": "npm test"
    }
  }
}
DorianGrey commented 5 years ago

This should be the correct configuration. I cannot reproduce this issue, either. Do you have an exemplary repository illustrating this issue?