search

wmorgan / heliotrope

A personal, threaded, search-centric email server.
124 stars 17 forks source link

heliotrope-reindex #22

Closed tjheeta closed 13 years ago

tjheeta commented 13 years ago

heliotrope-reindex - when re-ordering the index, there was a discrepancy between the whistlepig and meta-index doc_id's. To maintain the correlation so that search works correctly, rebuilding the meta-index also.

Does not include the sort_by! change for older ruby versions in the other pull request.

Makes the reindexing a bit slower, but the only other way I could think of doing it was adding a correlation field in the meta-index and then modifying the heliotrope-server. Seemed a little too complicated for a trial run.

wmorgan commented 13 years ago

Yeah, I'm aware of this problem and have been mulling over which approach to take for probably a few weeks now. :) I'm leaning towards adding a correlation field, since I think the performance implications will be minimal, and it buys us a little independence between the components. But if I try it and it really slows things down, I will come back to this approach.

Thanks for the patch, either way. Good catch.