search

wmutils / opt

optional addons to wmutils
Other
114 stars 24 forks source link

wew: add click event fixes #13

Closed pockata closed 8 years ago

pockata commented 8 years ago

As discussed in #8, this PR introduces fixes to the click event handling. Currently click events get captured by wew and don't get replayed to the window beneath.

These changes provide a nice and easy way to use click-to-focus instead of the default hover-to-focus behaviour. Theoretically this is faster than a number-crunching script because the X server gives you the ID of the underlying window directly.

A simple way to test this is to put this in your event watcher script:

4) if [ "$wid" != "$(pfw)" ]; then
        vroum.sh "$wid" &
    fi
;;

I've been running these changes for a few weeks now without any problems. The only caveat is that event XCB_BUTTON_RELEASE (#5) doesn't get registered with wew at all, so it currently can't be bound. I've spend some time trying to figure out why this is happening, but it's beyond me (though I doubt someone will actually find it useful).

@z3bratabs let me know if you have any remarks.

z3bra commented 8 years ago

Thanks for the patch. We won't accept a patch to fix an issue if it brings another, obvious one. This is an interresting patch, but it needs to be fixed before being merged.

pockata commented 8 years ago

You have a point here. I'll keep this PR open in case someone else interested swoops in and makes a fix of my 'fix' or at least use it as a starting point. I'm currently lacking the free time necessary to address this issue, but I will return to it eventually.

z3bra commented 8 years ago

Rosen Stoyanov wrote:

You have a point here. I'll keep this PR open in case someone else interested swoops in and makes a fix of my 'fix' or at least use it as a starting point. I'm currently lacking the free time necessary to address this issue, but I will return to it eventually.

Thanks for your comprehension. This is definitely something we need in wew, but we can't ethically accept PR that break programs explicitely.

We'll keep the PR open as a reminder, and as a starting point as you said.

z3bra commented 8 years ago

"click-to-focus" can be implemented using the "underneath.sh" script in contrib, as well as a keybinder.

lwilletts commented 8 years ago

underneath.sh isn't perfect. It won't work with any kind of dropdown menu.