search

wmwv / cosmo

Go cosmology library
MIT License
7 stars 2 forks source link

Check and correct test cases for wcdm_test, wacdm_test #17

Closed wmwv closed 6 years ago

wmwv commented 6 years ago

Check and correct test cases for wcdm_test, wacdm_test

  1. [x] Several of the tests appear to have been calculated with w0=-1 instead of w0=-1.2. Use astropy.cosmology.wCDM, w0waCDM to correct the expected values.
  2. [x] Check wcdm_test.go
  3. [x] Check wacdm_test.go
  4. [x] Correct the errors in the implementation that lead to those tests currently passing.
wmwv commented 6 years ago

The non-flat case isn't being tested in ComovingTransverseDistanceZ1Z2 for any of lambdacdm, wcdm, or wacdm.

wmwv commented 6 years ago

The elliptic integral simplification is only valid for flat LCDM. Adjusted lambdacdm.go to only use the simplification in this case.