search

wmww / gtk-layer-shell

A library to create panels and other desktop components for Wayland using the Layer Shell protocol
GNU General Public License v3.0
318 stars 16 forks source link

build: Make generating introspection data optional #110

Closed marv closed 2 years ago

marv commented 3 years ago

This allows source-based distributions to avoid having to build gtk and all it's dependencies with introspection support. Also cross-compilation is tricky when GI is involved, so this way one can cross-compile the project easily by just disabling the introspection data (it's enabled by default, so the behaviour isn't changed)

Replace this paragraph with your normal PR comment. Do NOT remove the agreement below. It simply means if you changed an MIT licensed file, the entire file remains MIT.

By opening this pull request, I agree for my modifications to be licensed under whatever licenses are indicated at the start of the files I modified

wmww commented 3 years ago

It looks like with this PR if g-ir-scanner is not found it will silently fail to build introspection, even if introspection is explicitly set to true. It would be better to raise an error in this case, so either g-ir-scanner is installed or introspection is explicitly turned off.

wmww commented 3 years ago

Looks like this is being superseded by #111, which is similar but does not do automatic detection.