search

wmww / gtk-layer-shell

A library to create panels and other desktop components for Wayland using the Layer Shell protocol
GNU General Public License v3.0
318 stars 16 forks source link

Add support for generating vapi files for Vala #120

Closed AdrianVovk closed 2 years ago

AdrianVovk commented 2 years ago

https://github.com/wmww/gtk-layer-shell/issues/5#issuecomment-1030992077

By opening this pull request, I agree for my modifications to be licensed under whatever licenses are indicated at the start of the files I modified

AdrianVovk commented 2 years ago

None of my machines run Ubuntu or Debian or apt, so I had to do some online sleuthing to find the package name for the README. Let me know if it is incorrect.

I tested this setup and it works in my distro's environment

AdrianVovk commented 2 years ago

I set the vapi option to false by default, to prevent builds from breaking from the sudden new dependency on valac. Let me know if you'd want me to default it to true.

wmww commented 2 years ago

Thanks! Defaulting to on should be fine. Looks good to go as soon as you can get CI to pass.

AdrianVovk commented 2 years ago

Alright I made it build with -Dvapi=true by default. This should also fix the CI

AdrianVovk commented 2 years ago

Oops :upside_down_face: Now it'll build with -Dvapi=true by default

wmww commented 2 years ago

Is getting this released soon important, or is it being in master good enough for you?

AdrianVovk commented 2 years ago

@wmww master is good enough for me! This library doesn't change too rapidly