search

wneessen / go-mail

📧 Easy to use, yet comprehensive library for sending mails with Go
https://go-mail.dev
MIT License
567 stars 44 forks source link

Fix typo / inconsistency in Msg method #278

Closed alfa-alex closed 1 month ago

alfa-alex commented 1 month ago

The method SetAttachements is probably a typo: In all other methods it's correctly written "Attachments", so this method should be aligned.

wneessen commented 1 month ago

Appreciate the PR @alfa-alex!

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.88%. Comparing base (3e4d8e3) to head (7caf0b8).

Files Patch % Lines
msg.go 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #278 +/- ## ========================================== - Coverage 85.35% 79.88% -5.48% ========================================== Files 25 25 Lines 2076 2078 +2 ========================================== - Hits 1772 1660 -112 - Misses 179 298 +119 + Partials 125 120 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wneessen commented 1 month ago

It'll fix the linter errors in a dedicated PR. No need to do anything here

alfa-alex commented 1 month ago

Appreciate the PR @alfa-alex!

You're welcome. And thank you for the fast merge of this MR. And, even more, for your great work on this library! :tada: