RUSTSEC-2021-0145: Potential unaligned read

[github-actions[bot]]

Potential unaligned read

Details
Status	unsound
Package	atty
Version	0.2.14
URL	https://github.com/softprops/atty/issues/50
Date	2021-07-04

On windows, atty dereferences a potentially unaligned pointer.

In practice however, the pointer won't be unaligned unless a custom global allocator is used.

In particular, the System allocator on windows uses HeapAlloc, which guarantees a large enough alignment.

atty is Unmaintained

A Pull Request with a fix has been provided over a year ago but the maintainer seems to be unreachable.

Last release of atty was almost 3 years ago.

Possible Alternative(s)

The below list has not been vetted in any way and may or may not contain alternatives;

• std::io::IsTerminal - Stable since Rust 1.70.0
• is-terminal - Standalone crate supporting Rust older than 1.70.0

See advisory page for additional details.

[matheus23]

For anyone reading this: atty is only in the dependency tree for the benchmarking crate (due to criterion):

atty v0.2.14
└── criterion v0.4.0
    [dev-dependencies]
    └── deterministic-bloom-benches v0.1.0 (/home/philipp/program/work/deterministic-bloom/deterministic-bloom-benches)

The fix is to update to criterion 0.5.1.