wnfs-wg / rs-wnfs

Rust implementation of the WebNative FileSystem (WNFS) specification
https://github.com/wnfs-wg
Apache License 2.0
147 stars 24 forks source link

RUSTSEC-2021-0145: Potential unaligned read #233

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

Potential unaligned read

Details
Status unsound
Package atty
Version 0.2.14
URL https://github.com/softprops/atty/issues/50
Date 2021-07-04

On windows, atty dereferences a potentially unaligned pointer.

In practice however, the pointer won't be unaligned unless a custom global allocator is used.

In particular, the System allocator on windows uses HeapAlloc, which guarantees a large enough alignment.

atty is Unmaintained

A Pull Request with a fix has been provided over a year ago but the maintainer seems to be unreachable.

Last release of atty was almost 3 years ago.

Possible Alternative(s)

The below list has not been vetted in any way and may or may not contain alternatives;

See advisory page for additional details.

matheus23 commented 1 year ago
$ cargo tree -i atty
atty v0.2.14
└── criterion v0.4.0
    [dev-dependencies]
    └── wnfs-bench v0.1.20 (/home/philipp/program/work/rs-wnfs/wnfs-bench)

criterion doesn't have a new version yet, and this vulnerability doesn't apply in our case: We don't use a custom global allocator, and finally, this is only a dev-dependency of a benchmark crate that we don't even publish. So I'll close this.