Closed valduris closed 4 years ago
Hi and thank you for the PR.
This seems like a good thing to fix. Have you considered if your fix works for multiple .listenTo
calls? It seems to me that the variable you introduced is shared across all object instances, and could therefore stop working when having multiple objects. I would consider binding that variable to each object instance instead like so: getState(element).checkForObjectDocumentTimeoutId = ...
.
I would also be very happy if you would provide a test case for this, to avoid future regression.
Cheers
@wnr , I've updated the PR as You requested, but it seems all unit tests for "object" strategy are disabled, so I haven't added any.
@valf Thank you. Looks good to me now. Yes, I forgot those tests was disabled for the CI env.
…runtime error