wnr / element-resize-detector

Optimized cross-browser resize listener for elements.
MIT License
1.32k stars 118 forks source link

Object is focusable with tab #67

Closed ghost closed 7 years ago

ghost commented 7 years ago

Would it be possible to add

object.tabIndex = -1;

wnr commented 7 years ago

Yes, that should work. I'll accept such PR, or do it myself in the near future. However, please note that the object approach is deprecated (use the scroll approach instead).

ioquatix commented 7 years ago

When will scroll approach become the default?

wnr commented 7 years ago

In the next major bump (2.0.0). Please note that there is no planned major bump at this time, as I do not want to bump major just for the default value of the strategy option. If something bigger in the future needs to bump major, I'll change the default value at the same time.

wnr commented 7 years ago

The object tab index issue is now fixed in release 1.1.10