CLSCompliant - Githubissues

wo80 / CSparse.NET

A concise library for solving sparse linear systems with direct methods.

GNU Lesser General Public License v2.1

58 stars 25 forks source link

CLSCompliant #26

Closed epsi1on closed 4 years ago

epsi1on commented 4 years ago

Hello, For making the CSparse.NET CLSCompliant, these minor changes are needed:

error

Convert Matrix.rowCount and Matrix.colCount accesors from protected into internal
Change name of either Converter.FromDenseArray<T>(T[][] array) or FromDenseArray<T>(T[,] array) in order to have different names.

Do you agree to do these changes? and then from other .net languages like VB.Net, CSparse.NET is accessible

wo80 commented 4 years ago

Hey there, hope you're doing well!

I don't give too much about VB, but it's probably a good idea to be CLS compliant. I'd rather rename rowCount, columnCount than changing the visibility. I'll have a look into it.

epsi1on commented 4 years ago

Thanks, This is also required:

Change name of either Converter.FromDenseArray(T[][] array) or FromDenseArray(T[,] array) in order to have different names.

epsi1on commented 4 years ago

Hi, Any news? Do you need any help on this? just tell me what will you rename rowCount and columnCount to, i can do it...

wo80 commented 4 years ago

Sorry for delay, totally forgot about this one :(