search

wo80 / csparse-interop

C# bindings for sparse matrix solvers.
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

Any plan to support MKL sparse QR? #18

Closed hxhc closed 2 months ago

hxhc commented 9 months ago

Dear @wo80 ,

Thanks for the great work to help using sparse sovlers in C#. I am a newbie to sparse sovlers and I made a incomprehensive survey of direct solvers. Obviously suitesparse and pardiso are the most common solvers, which you have already integrated into the project.

While it is quite fast especially for large matrices, according to your benchmark result, pardiso can only cope with square matrices. MKL has introduced sparse qr solver which shows much higher performance over SuiteSparse SPQR. I am wondering if you have any plan to implement the interface between CSparse.net and mkl Sparse QR. Since I am a newbie to both sparse sovlers and C#, I just can't make a PR in short time. If you are busy, maybe I can try a simple version some time later. Anyway, the project is terrific, thank you again!

wo80 commented 9 months ago

Oh, thanks for reminding me! I already wrote the wrapper when the sparse qr code was first released a couple of years ago. I was hoping that support for complex matrices would be added, so I didn't release the code. Totally forgot about it.

I guess it's fair to assume that Intel has no plans to add complex matrix support, so I might as well just add it to the repo now.

hxhc commented 9 months ago

Glad to hear that, closing the issue for you have already written the code.😁

wo80 commented 9 months ago

The code is online now. Please test and report any issues.

hxhc commented 9 months ago

The code is online now. Please test and report any issues. Sure, I'll test the function soon.