woboq / iquassel

iOS Quassel IRC client
Other
11 stars 4 forks source link

Adding/removing networks on core unexpectedly disconnects #26

Open phuzion opened 4 years ago

phuzion commented 4 years ago

Summary:

When a new network is added to the core, any connected iQuassel clients will unexpectedly disconnect.

Steps to reproduce:

Expected behavior:

The buffer list in iQuassel should be updated to reflect the new network

Actual behavior:

The iQuassel client reports "Error" and "Please reconnect to core"

guruz commented 4 years ago

This was done for easier implementation ;-) https://github.com/woboq/iquassel/blob/0e2b90b164ad84a852c948ee35b76e94892f1446/quassel-for-ios/quassel-for-ios/QuasselCoreConnection.m#L907

It is done at a few places as the iOS client anyway is disconnecting more often than a desktop client

guruz commented 4 years ago

TODO: Set the 'reconnect' flag so at least we auto-reconnect