fix clang-10 support - Githubissues

woboq / moc-ng

A reimplementation of Qt's moc using libclang. Contains both a drop-in remplacement, and a plugin for the clang compiler.

https://woboq.com/blog/moc-with-clang.html

GNU General Public License v3.0

204 stars 24 forks source link

fix clang-10 support #16

Open bjornstromberg opened 4 years ago

bjornstromberg commented 4 years ago

added preprocessor directives to:
- support for clang/llvm >= 10 which uses smartptr's instead of rawpointers.
- support for clang/llvm < 10 which uses raw pointers.
- bump required C++ version from 11 to 14, since Clang-10 requires C++14 to build, and clang-9 builds fine with it.

tested so it builds fine with clang-9 + clang-10.

CLAassistant commented 4 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

bjornstromberg commented 4 years ago

well i wont sign any CLA, i'm no lawyer and i don't care that much to read into the agreement. I've made the changes public on github, should be sufficent for GPLv3.

so i guess that will make this upstream pull request will never get merged.