woboq / tr

Translation tools for rust
57 stars 9 forks source link

Please consider providing a `Cargo.lock` #21

Open vikanezrimaya opened 8 months ago

vikanezrimaya commented 8 months ago

Current Rust best practices recommend committing Cargo.lock even for libraries: https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html

Additionally, this makes downstream packaging easier in some places, like nixpkgs, where a Cargo.lock is mandatory for Rust packages. I would love to package the xtr utility for nixpkgs, but the lack of Cargo.lock in your repository complicates things somewhat (while an out-of-tree Cargo.lock can be provided, it would be nice to have it provided in the repository).

Since this package provides an executable binary, it makes sense to provide a Cargo.lock in this repository even under the old guidelines.

ogoffart commented 8 months ago

I'm not a fan of putting the lock file in the repository. This is a tradeoff, and i think it just messes the git history.

Now, if this helps to get xtr packaged, I might reconsider this.