search

woboq / verdigris

Qt without moc: set of macros to use Qt without needing moc
https://woboq.com/blog/verdigris-qt-without-moc.html
GNU Lesser General Public License v3.0
643 stars 60 forks source link

rename property macros #32

Closed pkrenz closed 4 years ago

pkrenz commented 6 years ago

WRITE, READ, etc are quite common names, so using a slightly different naming conforming to the other macros should be safer for integration in other projects

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

ogoffart commented 6 years ago

I'm afraid I can't change the name of these macro just like that. I want to keep compatibility. Maybe however I could use a #ifndef W_NO_DEFINE_PROPERTIES_MACRO or something like that so they wouldn't be defined.

WSoptics commented 6 years ago

Downward compatibility is definitely important. I must say I am not the biggest fan of defines as there is some error potential depending where W_NO_DEFINE_PROPERTIES_MACRO is defined.

How about moving everything but the macros and related code to a separate header which then can just be included in wobjectdefs.h. That way wobjectdefs.h works the same way is does now and the macros could easily be avoided by just including the new header.

ogoffart commented 4 years ago

Replaced by commit 24af648aeb59c0ab06966fcfe9bcc246729c6153 Add the W_NO_PROPERTY_MACRO define in your project not to define these macros