search

woboq / verdigris

Qt without moc: set of macros to use Qt without needing moc
https://woboq.com/blog/verdigris-qt-without-moc.html
GNU Lesser General Public License v3.0
638 stars 58 forks source link

some cleanups #56

Closed arBmind closed 5 years ago

arBmind commented 5 years ago
  1. std::make_index_sequence should be faster than any hand written code on most compilers. It can and should use intrinsics.
  2. sums can be implemented without recursion.
  3. There is no need for the StaticString type to carry the index_sequence in the name. Also the constructor is not necessary (rule of 0) - same as std::array.
ogoffart commented 5 years ago

Looks like the MSVC on appvoyer can't cope with these changes.

tst_qobject.cpp
c:\projects\verdigris\src\wobjectdefs.h(221): fatal error C1202: recursive type or function dependency context too complex
..\..\..\src\wobjectimpl.h(38): note: see reference to function template instantiation 'w_internal::StaticString<1270> w_internal::makeStaticString<1270>(const char (&)[1270])' being compiled
..\..\..\src\wobjectimpl.h(36): note: while compiling class template member function 'w_internal::StaticString<1270> w_internal::concatenate_helper<std::integer_sequence<_Ty,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134,135,136,137,138,139,140,141,142,143,144,145,146,147,148,149,150,151,152,153,154,155,156,157,158,159,160,161,162,163,164,165,166,167,168,169,170,171,172,173,174,175,176,177,178,179,180,181,182,183,184,185,186,187,188,189,190,191,192,193,194,195,196,197,198,199,200,201,202,203,204,205,206,207,208,209,210,211,212,213,214,215,216,217,218,219,220,221,222,223,224,225,226,227,228,229,230,231,232,233,234,235,236,237,238,239,240,241,242,243,244,245,246,247,248,249,250,251,252,253,254,255,256,257,258,259,260,261,262,263,264,265,266,267,268,269,270,271,272,273,274,275,276,277,278,279,280,281,282,283,284,285,286,287,288,289,290,291,292,293,294,295,296,297,298,299,300,301,302,303,304,305,306,307,308,309,310,311,312,313,314,315,316,317,318,319,320,321,322,323,324,325,326,327,328,329,330,331,332,333,334,335,336,337,338,339,340,341,342,343,344,345,346,347,348,349,350,351,352,353,354,355,356,357,358,359,360,361,362,363,364,365,366,367,368,369,370,371,372,373,374,375,376,377,378,379,380,381,382,383,384,385,386,387,388,389,390,391,392,393,394,395,396,397,398,399,400,401,402,403,404,405,406,407,408,409,410,411,412,413,414,415,416,417,418,419,420,421,422,423,424,425,426,427,428,429,430,431,432,433,434,435,436,437,438,439,440,441,442,443,444,445,446,447,448,449,450,451,452,453,454,455,456,457,458,459,460,461,462,463,464,465,466,467,468,469,470,471,472,473,474,475,476,477,478,479,480,481,482,483,484,485,486,487,488,489,490,491,492,493,494...
arBmind commented 5 years ago

Looks like the MSVC on appvoyer can't cope with these changes.

If have seen this. AppVeyor uses VS2017. There is no obvious complexity change involved in this cleanup. So I guess it was already close to the maximum and something triggered it. Adding tuples with #57 resolves this for VS2017, as concatenate is implemented without recursion. Therefore I did not bother too much here.