search

woboq / verdigris

Qt without moc: set of macros to use Qt without needing moc
https://woboq.com/blog/verdigris-qt-without-moc.html
GNU Lesser General Public License v3.0
638 stars 58 forks source link

Make all tests discoverable by QtCreator #64

Closed arBmind closed 5 years ago

arBmind commented 5 years ago

QtCreator parses the source files to discover tests. When we arrange the tests the right way - they can be found.

It seems too many or too big macros are an issue.

ogoffart commented 5 years ago

I don't really like this change because it will cause problem to maintain these tests: These test are somehow sync'ed form Qt upstream (see the tests/qt/README file) and so i'd avoid departing away from the upstream tests. And the reason why the W_SLOT are directly next to the slot declaration has the advantage to force a merge conflict so we do not forget to add the W_SLOT when a slot is added upstream. (otherwise the test would be silently ignored (as in: not run).

I'm Ok removing the comments in slot if that helps though.