search

woboq / verdigris

Qt without moc: set of macros to use Qt without needing moc
https://woboq.com/blog/verdigris-qt-without-moc.html
GNU Lesser General Public License v3.0
638 stars 58 forks source link

Removing potential warning. #71

Closed MaxMatti closed 5 years ago

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

ogoffart commented 5 years ago

Thanks for the patch.

[[maybe_unused]] is C++17 only and I still want to support C++14

You can try to use Q_DECL_UNUSED instead

MaxMatti commented 5 years ago

Thanks for the fast reply, I updated the branch. I wasn't really sure on wether it is okay to create a PR for such a small change, mostly because I could not find a guideline for contributions in the usual places. What is your preferred method of contributing such small bits?

ogoffart commented 5 years ago

What is your preferred method of contributing such small bits?

A PR like you did is fine. Thanks.