search

wobscale / EuIrcBot

A featureful nodejs irc bot
MIT License
14 stars 15 forks source link

Create unshorten module #197

Closed Abdiramen closed 6 years ago

Abdiramen commented 6 years ago

Implements unshortening from issue #29.

LinuxMercedes commented 6 years ago

I'm just checking from my phone so forgive me if this is obvious, but what is file.txt for?

On Fri, Jun 1, 2018, 13:33 Abdirahman Ahmed Osman notifications@github.com wrote:

Implements unshortening from issue #29 https://github.com/euank/EuIrcBot/issues/29.

You can view, comment on, or merge this pull request online at:

https://github.com/euank/EuIrcBot/pull/197 Commit Summary

  • Create unshorten module

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/euank/EuIrcBot/pull/197, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJJ-8fgUkPOs48DZDi6q4mz4U_ypGL4ks5t4YjtgaJpZM4UXIl5 .

euank commented 6 years ago

Code-wise LGTM.

One last nit is that I think the commits should be squashed (no need for file.txt to be in our git log), and I've been using a 'subsystem' style commit message format generally, so e.g. the commit message here would be prefixed with 'modules/unshorten'

Abdiramen commented 6 years ago

@euank took a second to figure out how to remove commits but I think everything should to satisfactory now.