search

wocommunity / wolips

wolips
53 stars 53 forks source link

Make WOLips build with Eclipse 2020-09 (4.17.0) #147

Closed lbane closed 3 years ago

lbane commented 4 years ago

This seems to restore the EOModeler functionality #146, but more tests are needed. The build will only work with Java 11+, because some needed Eclipse classes have the corresponding class file version 55. The changes to the workspace mechanic plugin are similar to PR 141.

hprange commented 3 years ago

Anybody else has a reason not to merge this change into the eclipse_4_10 branch?

lbane commented 3 years ago

The updated plugin will not work with older versions of Eclipse, that run with Java 8. Maybe it is better to create a new branch (and corresponding distribution directory), or somehow restrict the installation to new Eclipse versions.

rxmz20 commented 3 years ago

Since this is intended to address an issue with the current Eclipse, and presumably moving forward, my vote would be to keep it on the main branch. People using older Eclipse versions could just use the previous build, correct?

rxmz20 commented 3 years ago

Just bumping this discussion. As I understand it, any WOLips user who wants to run the most recent Eclipse 2020-09 (or 2020-12) currently has to check out this branch and build WOLips themselves (or be lazy and do what I'm currently doing—press on without EOModeler functionality). Can this be safely merged? Thanks!

Wolfy42 commented 3 years ago

@rxmz20 You have to be aware that this changes are necessary to run an newer versions of eclipse which is requiring Java11. But after the merge this plugin will be broken in all old versions of eclipse, which some people may still using!

So following experiment would be necessary:

  1. Use an "old" eclipse (eclipse-version < 2020 without Java11 support)
  2. Install wolips from the jenkins (https://jenkins.wocommunity.org/job/WOLips410/)
  3. Build this branch somewhere (server or to a local zip-file)
  4. Point your old wolips-update-site to the build of this branch
  5. Eclipse will detect that there is an update

Following things could happen:

Option A: Eclipse checks the updated jars and tell you that this is not compatible (This would be good) Option B: Eclipse installs the jars and afterwards wolips is completely broken (This would be bad)

If someone does this experiment and the result is Option-A then it is save to merge. If the outcome is Option-B then it should not be merged, because you break many (still working) eclipses with wolips.

sgaertner commented 3 years ago

Since new Eclipse versions can be used to develop using older JDK versions, is there any reason to stick with an old Eclipse version?

maiksd commented 3 years ago

@lbane Could you please change the base branch of this to master?