search

wocommunity / wolips

wolips
53 stars 53 forks source link

Use LF when building UNIX appstart file on windows #150

Open fbarthez opened 3 years ago

fbarthez commented 3 years ago

This change ensures UNIX-style LF line breaks are used in the application start-up script file, when building on a Windows machine.

nullterminated commented 2 years ago

This requires a maven release like your previous PR did for the woproject-ant-tasks? I'm not sure I should touch it. Maybe @hprange can handle this one or let me know how or both :)

hprange commented 2 years ago

Hey @fbarthez. I know this is long overdue. Do I need to merge this pull request and make a release of woproject-ant-tasks after that? Is this fix intended to be applied to the Maven build as well?

fbarthez commented 2 years ago

Hey @hprange, thanks for taking this up. Yes, it should be applied to the maven build as well. IIRC that means releasing woproject-ant-tasks and then using the new version in the maven plugin. (It's been a long time though and I haven't had to build anything on Windows for years.)