search

wocommunity / wolips

wolips
53 stars 53 forks source link

Support for Eclipse 4.26 #172

Closed lbane closed 1 year ago

lbane commented 1 year ago

Adds support for Eclipse 4.26

The most glaring problem in Eclipse 4.26 is the deprecation and removal of the classes BeansObservables and SWTObservables. There are two replacement classes BeanProperties and WidgetProperties with similar functionality, but slightly different call syntax. The code got adjusted to use these classes. A few additional compiler warnings are also fixed, but a lot more remain. I also propose to update the plugins for Java 11 compatibility, as this is the minimum version required by Eclipse.

In my testing the plugins run so far, without obvious more bugs than they already have. I'm not sure about backward compatibility, but in theory the "new" classes are already a few years old.

nullterminated commented 1 year ago

lol, I could have saved some time this weekend if I checked the PRs first. Your PR makes #173 redundant. I'm okay with it if yours is the winner here :)

nullterminated commented 1 year ago

It seems like commit https://github.com/wocommunity/wolips/pull/172/commits/2246b25c20bcd737e7433f85199a1734bd5ebb6f is causing issues with the build which is using an older version of Eclipse for the EclipseHome. My guess is either the referenced eclipse installation needs updating or this commit needs to rollback for the build to succeed.

nullterminated commented 1 year ago

It seems removing those changes did the trick and the build is working again. It might be a little ambitious, but feel free to resubmit them on a separate pr. We can add them when the eclipsehome is next updated.

lbane commented 1 year ago

lol, I could have saved some time this weekend if I checked the PRs first. Your PR makes #173 redundant. I'm okay with it if yours is the winner here :)

I'm sorry, I should have communicated it on the list, that I was working on this.

lbane commented 1 year ago

It seems like commit 2246b25 is causing issues with the build which is using an older version of Eclipse for the EclipseHome. My guess is either the referenced eclipse installation needs updating or this commit needs to rollback for the build to succeed.

Which Eclipse version have you used?

nullterminated commented 1 year ago

No apologies or pre-announcing necessary. I'm glad to receive the contribution.

Which Eclipse version have you used?

I'm using 2022-12, but the EclipseHome on the build server is something older. I'm not sure what it is. Based on the classpath of veogen when I started working on this also, it was something released on or after 2020.