search

wocommunity / wolips

wolips
53 stars 53 forks source link

Visualize deprecation status of bindings in editors #91

Closed darkv closed 12 years ago

darkv commented 12 years ago

This patch adds validation checks for deprecated classes/methods/variables so that the popup menus with completion proposals in the HTML and Wod editor display bindings stroked through. Additionally warning/error markers are created for deprecated elements and bindings. This can be controlled by adding a setting to the WOLips validation preference pane.

What would be nice is that those deprecated elements are displayed stroked through in the editors too. As far as I could analyze the code simple textual scanners are used to colorize the HTML/Wod code. As there is no direct connection to the underlying Java code either the retrieval of the corresponding IType objects would probably be costly or the parsing mechanism of the editor should be altered. Either of those two choices would go beyond what I am able to do right now.

qdolan commented 12 years ago

This looks pretty good. Just a couple of comments:

  1. Please try to avoid mixing totally unrelated changes in your pull request. ie. The changes to use .valueOf() are good, but detracts from being able to review the deprecation stuff more easily. Ideally these would be two separate change requests.
  2. Please set your workspace formatter style to match the existing codebase (don't recall the exact settings, but I think it may be indent = 2, spaces only). If you turn on "Show whitespace characters" in your editor you will see that you are mixing space and tab indentation.
darkv commented 12 years ago

Ok good points, I will recreate the pull request(s).